[PATCH] D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 13:51:50 PDT 2020


stefanp updated this revision to Diff 286133.
stefanp added a comment.

I've tried to address the concerns for this patch. I'm sorry that it took so long to make the code changes.

I did try to generate the assembly equivalent of the tests but those will not work. The PowerPC MC layer will assert if I try to generate an object file from assembly that does not have the correct relocations.
I did the fix the tests using the original suggestion of `yaml2obj`.

I also fixed the out of bounds problem by passing the start iterator to the function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85994/new/

https://reviews.llvm.org/D85994

Files:
  lld/ELF/Relocations.cpp
  lld/test/ELF/ppc64-error-missing-tlsgdld.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85994.286133.patch
Type: text/x-patch
Size: 12630 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200817/22485273/attachment.bin>


More information about the llvm-commits mailing list