[PATCH] D85838: New TableGen Programmer's Reference document

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added a comment.

In D85838#2222091 <https://reviews.llvm.org/D85838#2222091>, @nhaehnle wrote:

> In D85838#2222073 <https://reviews.llvm.org/D85838#2222073>, @Paul-C-Anagnostopoulos wrote:
>
>> In D85838#2222000 <https://reviews.llvm.org/D85838#2222000>, @nhaehnle wrote:
>>
>>> First of all, thank you for doing this. I haven't gone through it fully yet. The main thing that is missing in my opinion is to **remove** stuff from the existing files. You include here a listing of TableGen syntax -- that's fine, but it's now redundant with what's in `TableGen/LangRef.rst`, and this redundancy is a very bad place for us to be in.
>>
>> You are most welcome. My plan was to get this committed first. Note that this includes an update to the TableGen Overview to refer to this document rather than the two old ones. A search turns up no other references to the two old documents in the Clang or LLVM documentation. Then once this is committed, we can delete the two old files. (Is that what we do, delete them?)
>
> Why not just delete them at the same time? (them = LangIntro.rst and LangRef.rst, I assume) Making the change atomically like that feels more "right" to me. And after actually scanning those two docs again, yes, I agree that we can just delete them.
>
>> Shall I wait for additional review comments from you?
>
> I've sent a few more a few minutes ago, but that should cover it as far as I'm concerned.

I will address your comments and submit a final patch.

But please tell me how to delete the two old files. Do I simply do a 'git rm' and then commit that along with the final ProfRef.rst?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85838/new/

https://reviews.llvm.org/D85838