[PATCH] D86063: AMDGPU: Match global saddr addressing mode

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1789
+  // Match the variable offset.
+  if (Addr.getOpcode() != ISD::ADD)
+    return false;
----------------
rampitec wrote:
> You probably need to match OR as well, this is a canonical form.
This is for the variable offset, where add is less likely to turn into or. That's another edge case I'll look at in the next round (the other being SGPR base + imm offset should also probably use this with a 0 voffset instead of copying the base pointer)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86063/new/

https://reviews.llvm.org/D86063