[PATCH] D86079: [X86] Improved lowering for saturating float to int.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 11:50:00 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:281
 
+  if (Subtarget.hasSSE1()) {
+    // Custom lowering for saturating float to int conversions.
----------------
SSE1 only supports f32 in SSE registers. f64 requires SSE2


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:21068
+  // anything else.
+  if (SrcVT != MVT::f32 && SrcVT != MVT::f64) {
+    return SDValue();
----------------
Drop curly braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86079/new/

https://reviews.llvm.org/D86079



More information about the llvm-commits mailing list