[PATCH] D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 11:39:10 PDT 2020


NeHuang added inline comments.


================
Comment at: lld/ELF/Relocations.cpp:1312
+    // above.
+    const RelTy &prevRel = *(i - 2);
+    RelType prevType = prevRel.getType(config->isMips64EL);
----------------
Better to execute `line 1312 and 1313` only when 
```
    if (((type == R_PPC64_REL24 || type == R_PPC64_REL24_NOTOC) &&
         sym.getName() == "__tls_get_addr") 
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85994/new/

https://reviews.llvm.org/D85994



More information about the llvm-commits mailing list