[PATCH] D85852: Fix two bugs in TGParser::ParseValue
Nicolai Hähnle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 17 11:31:30 PDT 2020
nhaehnle added a comment.
> Do I need to reformat the code as Lint suggests? Most of the if (!xxx) return ... tests in the code are on one line.
Yes, please do. Those single-line checks are increasingly rare in the LLVM code base for IMHO good reasons, let's not add new ones even if this code happens to be fairly old and not follow newer customs.
The change LGTM apart from that, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85852/new/
https://reviews.llvm.org/D85852
More information about the llvm-commits
mailing list