[PATCH] D83468: [Debuginfo] Fix for PR46653

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:107
 
-  MIRBuilder.setInstrAndDebugLoc(MI);
+  MIRBuilder.setInstr(MI);
 
----------------
Jac1494 wrote:
> aprantl wrote:
> > This also looks wrong. We would be inheriting a random previous debug location for all instructions created by MIRBuilder if we did this?
> Yes, I have also check the debugging experience and now it is looks correct.
Pretty sure this is completely broken. The currently legalizing instruction is the only reasonable choice to set here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83468/new/

https://reviews.llvm.org/D83468