[PATCH] D85838: New TableGen Programmer's Reference document

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

First of all, thank you for doing this. I haven't gone through it fully yet. The main thing that is missing in my opinion is to **remove** stuff from the existing files. You include here a listing of TableGen syntax -- that's fine, but it's now redundant with what's in `TableGen/LangRef.rst`, and this redundancy is a very bad place for us to be in.



================
Comment at: llvm/docs/TableGen/ProgRef.rst:57
+
+Classes and concrete records have a unique *name*. Associated with that name
+is a list of *fields* with values and an optional list of *superclasses*
----------------
This is only partially true. Anonymous `def`s are a thing. They end up having a standing name like `anonymous_NNNN`, but that doesn't tend to be very useful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85838/new/

https://reviews.llvm.org/D85838