[PATCH] D85197: GlobalISel: Implement fewerElementsVector for G_CONCAT_VECTORS sources

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:253
   for (int I = 0; I != NumResults; ++I)
-    Regs[I] = MI.getOperand(I).getReg();
+    Regs[StartIdx + I] = MI.getOperand(I).getReg();
 }
----------------
aemerson wrote:
> Why these changes to this function? The new behavior doesn't match the comment for it.
Before it would clear the original vector, so you couldn't repeatedly call this and accumulate in Regs without a temporary vector. This switches it to append


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85197/new/

https://reviews.llvm.org/D85197