[PATCH] D83884: GlobalISel: Make type for lower action more consistently optional

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 10:40:31 PDT 2020


arsenm added a comment.

In D83884#2221900 <https://reviews.llvm.org/D83884#2221900>, @aemerson wrote:

> Is the intention of the type arg to be something to only attempt to get to, or something that's expected to lower to otherwise there's a legalization failure?

I was thinking of it as a hint, not required. It doesn't necessarily mean anything for all lowerings.

For the purpose of this change alone, there's no use of the type parameter. This just fixes lower working or not depending on which path you set the legalizer rule through


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83884/new/

https://reviews.llvm.org/D83884



More information about the llvm-commits mailing list