[PATCH] D86020: [MemCpyOptimizer] Optimize passing byref function arguments down the stack

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 09:40:59 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/test/Transforms/MemCpyOpt/byref-memcpy.ll:44
+}
+
+declare void @leaf(%struct.S* byref(%struct.S) align 4)
----------------
I think this is missing an alignment check. Can you add a test where the callee requires a higher parameter alignment than the caller?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86020/new/

https://reviews.llvm.org/D86020



More information about the llvm-commits mailing list