[PATCH] D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:93
+  }
+  void AddAllocateObject(SymbolRef object) {
+    allocateObjects_.insert(object);
----------------
Check whether this kind of clause is present in OpenACC also. If not then move it to the OmpDirectiveVisitor class.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:111
   SymbolSet dataSharingAttributeObjects_; // on one directive
+  SymbolSet privateDataSharingAttributeObjects_;
+  SymbolSet allocateObjects_;
----------------
Is this field required? Can we use an additional check (whether symbol is private) on the dataSharingAttributeObjects_ to obtain this set?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86051/new/

https://reviews.llvm.org/D86051