[PATCH] D85584: AMDGPU/GlobalISel: Legalize odd sized loads with widening

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:2303-2308
+  if (Ty.isVector()) {
+    const LLT EltTy = Ty.getElementType();
+    return LLT::vector(PowerOf2Ceil(Ty.getNumElements()), EltTy);
+  }
+
+  return LLT::scalar(PowerOf2Ceil(Ty.getSizeInBits()));
----------------
foad wrote:
> `Ty.changeElementSize(PowerOf2Ceil(Ty.getScalarSizeInBits()))`?
I think that should only be used to handle cases that could be a vector or not, but it’s known scalar here  so doesn’t save code 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85584/new/

https://reviews.llvm.org/D85584