[PATCH] D76434: [SCEV] Query expanded immediate cost at minsize

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp:2406
     // than the number of it's terms.
     BudgetRemaining -= PairCost * (NAry->getNumOperands() - 1);
     if (BudgetRemaining < 0)
----------------
>>! In D86072#2221367, @samparker wrote:
> In D76434 you highlighted by SCEVNAry expressions can have more than two operands, which would expand to a chain of operations, and the existing costs for AddRecExprs tries to account for that. But this was missing for normal Add and Mul expressions. Have I misunderstood you?

Doesn't look missing to me?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76434/new/

https://reviews.llvm.org/D76434