[PATCH] D85519: [llvm-readobj/elf] - Refine the code for broken PT_DYNAMIC segment diagnostic.

Mon Aug 17 06:42:44 PDT 2020

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/malformed-pt-dynamic.test:68-69
       - Section: .dynamic
+SectionHeaderTable:
+  NoHeaders: true
----------------
grimar wrote:
> jhenderson wrote:
> > Do we actually need to strip the section headers any more? I'm not sure the original issue really applies any more, as it was just to do with yaml2obj's previous limitations.
> I'll answer on this later. I am observing a different behavior without stripping headers - llvm-readobj complains about broken PT_DYNAMIC and says it going to use some information from the sections header instead. But I had no chance to investigate it better yet. 
> 
The behavior with and without the section header table is slightly different. In D86073 I am testing both cases.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85519/new/

https://reviews.llvm.org/D85519