[PATCH] D85740: Universal MachO: support LLVM IR objects

Adrien Guinet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 04:18:14 PDT 2020


aguinet updated this revision to Diff 285958.
aguinet added a comment.

Hello @alexshap,

Here is a new patch that includes:

- support for archives that includes LLVM IR objects
- testing using llvm-ar
- fix the order include in llvm-lipo (as per your comment)

It also includes a few refactoring of code.

I don't know how much we need to be consistent on the original lipo regarding the error message, but I tried to follow the existing convention.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85740/new/

https://reviews.llvm.org/D85740

Files:
  llvm/include/llvm/Object/Binary.h
  llvm/include/llvm/Object/MachOUniversal.h
  llvm/include/llvm/Object/MachOUniversalWriter.h
  llvm/lib/Object/Binary.cpp
  llvm/lib/Object/MachOUniversal.cpp
  llvm/lib/Object/MachOUniversalWriter.cpp
  llvm/test/tools/llvm-lipo/Inputs/arm64-ios.ll
  llvm/test/tools/llvm-lipo/Inputs/armv7-ios.ll
  llvm/test/tools/llvm-lipo/Inputs/x64-osx.ll
  llvm/test/tools/llvm-lipo/create-arch-ir.test
  llvm/test/tools/llvm-lipo/create-archive-input.test
  llvm/test/tools/llvm-lipo/info-universal-binary-ir.test
  llvm/test/tools/llvm-lipo/thin-universal-binary-ir.test
  llvm/tools/llvm-lipo/CMakeLists.txt
  llvm/tools/llvm-lipo/LLVMBuild.txt
  llvm/tools/llvm-lipo/llvm-lipo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85740.285958.patch
Type: text/x-patch
Size: 29312 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200817/3ddb37c8/attachment.bin>


More information about the llvm-commits mailing list