[PATCH] D80163: [X86][VARARG] Avoid spilling xmm registers for va_start.

Sun Aug 16 11:23:29 PDT 2020

RKSimon added a reviewer: efriedma.
RKSimon added a subscriber: efriedma.
RKSimon added a comment.

Do we need better i686- triple testing?

I don't know much about this area - @craig.topper  @efriedma any thoughts?

================
Comment at: llvm/lib/Target/X86/X86ExpandPseudo.cpp:483
+  // TODO: add support for YMM and ZMM here.
+  unsigned MOVOpc = STI->hasAVX() ? X86::VMOVAPSmr : X86::MOVAPSmr;
+
----------------
Any reason not to deal with YMM/ZMM as well?

================
Comment at: llvm/test/CodeGen/X86/x32-va_start.ll:2
 ; RUN: llc < %s -mtriple=x86_64-linux-gnux32 | FileCheck %s -check-prefix=CHECK -check-prefix=SSE
 ; RUN: llc < %s -mtriple=x86_64-linux-gnux32 -mattr=-sse | FileCheck %s -check-prefix=CHECK -check-prefix=NOSSE
 ;
----------------
Regenerate with update_llc ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80163/new/

https://reviews.llvm.org/D80163