[PATCH] D86026: Update lld test suite to include a substitution for the current LLVM version and make the test parametric

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/lit.cfg.py:86
 config.environment['LLD_IN_TEST'] = '1'
+config.substitutions.append(("%llvm_version", config.llvm_version))
 
----------------
mehdi_amini wrote:
> int3 wrote:
> > @ruiu has pushed back against using substitutions previously (in D77086). Could we just make the regex more flexible?
> I already made the regex less strict, if we can leave it as-is that works for us.
If we override the behavior with an environment variable, the lit substitution can be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86026/new/

https://reviews.llvm.org/D86026