[PATCH] D85544: [OpenMPOpt] ICV tracking for calls

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1467-1470
+        if (UniqueICVValue.hasValue() && UniqueICVValue != NewReplVal) {
+          UniqueICVValue = nullptr;
+          return false;
+        }
----------------



================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1484
+        continue;
+      }
+
----------------
Never reset `Changed`, see also below


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1491
+    return Changed;
+    // return UniqueICVValue;
+  }
----------------
leftover


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1537-1540
+      if (ReplVal == NewReplVal) {
+        Changed = ChangeStatus::UNCHANGED;
+        continue;
+      }
----------------
Never reset `Changed`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85544/new/

https://reviews.llvm.org/D85544