[PATCH] D85585: Replace TableGen range piece punctuator with '..'
Chris Lattner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 15 13:40:30 PDT 2020
lattner requested changes to this revision.
lattner added a comment.
This revision now requires changes to proceed.
This looks good to me, but please change this to "..." instead of "..". Also, in the documentation, please mention that this is an *inclusive* range. Thank you for working on this!
================
Comment at: llvm/lib/TableGen/TGLexer.h:46
paste, // #
+ range, // ..
----------------
The token name should follow their visual look, not their usage. This should be named "periodperiod" or perhaps "dotdot" (if so, change the "period" enum to "dot")
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85585/new/
https://reviews.llvm.org/D85585
More information about the llvm-commits
mailing list