[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked 12 inline comments as done.
tejohnson added a comment.

Addressed everyone's comments as well as the clang tidy warnings.

I had hoped to get the runtime part ready and uploaded today, but it looks like I won't make it. I'll be out all next week, so will get that sent when I'm back.



================
Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:614
+    for (auto &Inst : BB) {
+      if (isInterestingMemoryAccess(&Inst, &IsWrite, &TypeSize, &Alignment) ||
+          isa<MemIntrinsic>(Inst))
----------------
vitalybuka wrote:
> probably nicer to put output param into struct {} and rely on RVO
> as is it's hard to track if they are initialized
I decided to put them in a struct as you suggest but make it return Optional as that seemed cleaner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85948/new/

https://reviews.llvm.org/D85948