[PATCH] D85973: [PowerPC] Fix thunk alignment issue when using pc-rel instruction

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 12:22:20 PDT 2020


MaskRay added inline comments.


================
Comment at: lld/test/ELF/ppc64-thunk-alignment.s:1
+# REQUIRES: ppc
+# RUN: echo 'SECTIONS { \
----------------
I don't think the additional test is necessary. The address differences should be reflected by other tests.

Having too many tests for a feature is also something we should try to avoid.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85973/new/

https://reviews.llvm.org/D85973



More information about the llvm-commits mailing list