[PATCH] D85985: [MSAN] Convert ActualFnStart to be a particular Instruction *, not BB

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 12:04:53 PDT 2020


eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1087
     if (MS.CompileKernel)
-      ActualFnStart = insertKmsanPrologue(F);
+      ActualFnStart = insertKmsanPrologue(F)->getFirstNonPHI();
     else
----------------
Could you also change insertKmsanPrologue to get rid of BB splitting?
I'm thinking set ActualFnStart = F.getEntryBlock().getFirstNonPHI() in advance, then simply insert all the KMSan stuff into IRBuilder<>(ActualFnStart).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85985/new/

https://reviews.llvm.org/D85985



More information about the llvm-commits mailing list