[PATCH] D85759: [SLPVectorizer] Fix regression from cost model refactoring

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 10:38:13 PDT 2020


tlively added a comment.

Yes, I only made this patch because the previous one was intended to be NFC. However, I agree (based on my cursory understanding of the relevant code) that it would be better to have just one code path, but this patch enforces an additional use of the second code path. It would make further cleanup of this code easier if I left this as-is and just fixed the issue in the WebAssembly backend, so I think I will abandon this revision and do that instead. @samparker and @aheejin, does that sound reasonable to you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85759/new/

https://reviews.llvm.org/D85759



More information about the llvm-commits mailing list