[PATCH] D72423: [DemandedBits] Improve accuracy of Add propagator

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 07:50:00 PDT 2020


lebedev.ri added inline comments.


================
Comment at: llvm/test/Analysis/DemandedBits/add.ll:4
+
+; CHECK-DAG: DemandedBits: 0x1e for   %1 = and i32 %a, 9
+; CHECK-DAG: DemandedBits: 0x1a for   %2 = and i32 %b, 9
----------------
Is the order not deterministic?
It would be best to test everything there is in the output.


================
Comment at: llvm/test/Analysis/DemandedBits/add.ll:18
+  ret i32 %8
+}
----------------
RKSimon wrote:
> @rrika I'm going to pre-commit this to show trunk's current output, then you'll need to rebase so this patch shows the delta
Isn't there some transform pass based on demandedbits analysis?
Can that test be added to that pass, too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72423/new/

https://reviews.llvm.org/D72423



More information about the llvm-commits mailing list