[PATCH] D85959: [InstCombine] Remove unused entries in gc-liv bundle of statepoint
Denis Antrushin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 14 05:37:24 PDT 2020
dantrushin accepted this revision.
dantrushin added a comment.
This revision is now accepted and ready to land.
LGTM with couple nits inline
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1537
+ unsigned NumOfGCLives = LiveGcValues.size();
+ if (Bundle.hasValue() && NumOfGCLives != Bundle->Inputs.size()) {
+ // We can reduce the size of gc live bundle.
----------------
Change to early exit (break)
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1567
+ // Create new statepoint instruction.
+ OperandBundleDef NewBundle("gc-live", NewLiveGc);
+ if (isa<CallInst>(II))
----------------
Can we avoid creating empty bundles here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85959/new/
https://reviews.llvm.org/D85959
More information about the llvm-commits
mailing list