[PATCH] D85835: [llvm-readobj/elf] - Refine testing of broken Android's packed relocation sections.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 00:54:45 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/packed-relocs-errors.s:8
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/asm1.s -o %t1.o
+# RUN: llvm-readobj --relocations %t1.o 2>&1 | FileCheck %s -DFILE=%t1.o --check-prefix=ERR-HEADER
----------------
I could easily be misunderstanding how the -triple argument works, but don't we need a `-linux` suffix on here to ensure an ELF object is produced (as opposed to e.g. COFF or Mach-O) on all platforms, regardless of their default triple?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85835/new/

https://reviews.llvm.org/D85835



More information about the llvm-commits mailing list