[PATCH] D85368: [llvm][CodeGen] Machine Function Splitter

Aditya Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 00:10:26 PDT 2020


hiraditya requested changes to this revision.
hiraditya added a comment.
This revision now requires changes to proceed.

please run clang-format on the patch.



================
Comment at: llvm/lib/CodeGen/BasicBlockSections.cpp:232
+assignSections(MachineFunction &MF,
+               const std::vector<Optional<BBClusterInfo>> &FuncBBClusterInfo) {
   assert(MF.hasBBSections() && "BB Sections is not set for function.");
----------------
nit: tab?


================
Comment at: llvm/lib/CodeGen/BasicBlockSections.cpp:277
 
+// This function is exposed externally by BasicBlockSectionUtils.h
+void llvm::sortBasicBlocksAndUpdateBranches(
----------------
Is this comment necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85368/new/

https://reviews.llvm.org/D85368



More information about the llvm-commits mailing list