[PATCH] D84519: [llvm-objdump][AMDGPU] Detect CPU string

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:91
+
+  StringRef getAMDGPUCPUName() const;
+
----------------
scott.linder wrote:
> jhenderson wrote:
> > I know it's not the way the `get*Features` methods are written, but perhaps this should be a private method?
> I was thinking the same, but as you mention the convention here seems to be that these are public. If we think that is just an oversight maybe we can just follow up with a patch to hide all of them?
That would also be fine by me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84519/new/

https://reviews.llvm.org/D84519