[PATCH] D79485: [BPI] Improve static heuristics for "cold" paths.
Evgeniy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 13 22:36:39 PDT 2020
ebrevnov added a comment.
In D79485#2217052 <https://reviews.llvm.org/D79485#2217052>, @hiraditya wrote:
> Is this work based on any paper/implementation?
I don't propose anything completely new here. New algorithm does essentially the same as existing one but
1. fixes several correctness issues
2. extends the approach to handle loops and invokes in a universal way
> Can we add some documentation at the top of the file to get an overall idea of the cost model?
I don't think "cost model" is applicable here....anyway I can try to describe how thing work using some example. Is this what you are looking for?
================
Comment at: llvm/lib/Analysis/BranchProbabilityInfo.cpp:753
+ BBWeight = NORETURN_WEIGHT;
+ }
+ }
----------------
hiraditya wrote:
> do we have a tab here?
No, I don't have tabs in the code. Looks like phabricator represents indention increase by 4 this way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79485/new/
https://reviews.llvm.org/D79485
More information about the llvm-commits
mailing list