[PATCH] D85809: [lld] Enable remarks hotness filtering in lld and llvm-lto2

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/opt-remarks.ll:10
+; RUN: ld.lld --opt-remarks-with-hotness --opt-remarks-hotness-threshold=300 \
+; RUN: --opt-remarks-filename %t.t300.yaml %t.o -o %t -shared
+; RUN: ld.lld --opt-remarks-with-hotness --opt-remarks-hotness-threshold=301 \
----------------
For continuation lines, we usually indent by 2 columns.

This file was created in 2017, so some lines do not obey this rule. For new RUN lines you probably need to follow the rule.


================
Comment at: lld/test/ELF/lto/opt-remarks.ll:15
 ; RUN: cat %t.hot.yaml | FileCheck %s -check-prefix=YAML-HOT
+; RUN: cat %t.t300.yaml | FileCheck %s -check-prefix=YAML-HOT
+; RUN: count 0 < %t.t301.yaml
----------------
Replace `cat ... | cmd` with `cmd < ...`

Actually FileCheck supports `--input-file`, but since it is long, some people don't use it.


================
Comment at: llvm/test/LTO/Resolution/X86/diagnostic-handler-remarks-with-hotness.ll:20
+; RUN:           -r %t.bc,main,px -o %t.o %t.bc
+; RUN: cat %t.t300.yaml | FileCheck %s -check-prefix=YAML
+
----------------
`cat ... | cmd` => `cmd < ...`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85809/new/

https://reviews.llvm.org/D85809