[PATCH] D84334: [flang] Version information in flang/f18

Camille Coti via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 18:57:56 PDT 2020


coti added a comment.

Actually, I cannot find a way to make it work with `target_include_directories` on a clean build tree.

With `PRIVATE` I get an error at the next step, what is being compiled is expecting an input on stdin:

  [100%] Built target f18
  [100%] Generating /__fortran_builtins.mod
  Enter Fortran source
  Use EOF character (^D) to end file

With `PUBLIC`

  CMake Error in /home/users/coti/tmp/llvm-project/flang/tools/f18/CMakeLists.txt:
    Target "f18" INTERFACE_INCLUDE_DIRECTORIES property contains path:
  
      "/home/users/coti/tmp/tmpbuild/tools/flang/include/flang"
  
    which is prefixed in the build directory.
  
  
  CMake Error in /home/users/coti/tmp/llvm-project/flang/tools/f18/CMakeLists.txt:
    Target "f18" INTERFACE_INCLUDE_DIRECTORIES property contains path:
  
      "/home/users/coti/tmp/tmpbuild/tools/flang/tools/f18"
  
    which is prefixed in the build directory.

But, why not put `f18_version.h` in `${FLANG_BINARY_DIR}/include/flang`? This way we only need to include this directory, and it is not totally irrelevant to have the version numbers in this directory, is it? However, I still cannot make `target_include_directories` work (same as the first error).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84334/new/

https://reviews.llvm.org/D84334



More information about the llvm-commits mailing list