[PATCH] D85882: [AMDGPU] Update subtarget features for new target ID support

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nits, assuming the follow up change fixes some of the remaining hacks



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:900
+  if (XnackOnSupportRequested && DoesNotSupportXNACK)
+        errs() << "warning: Xnack On was requested for a processor that does not support it!\n";
+
----------------
Indentation


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:925
+
+  LLVM_DEBUG(dbgs() << "XNACK setting for subtarget: " << getXnackSetting() << "\n");
+  LLVM_DEBUG(dbgs() << "SRAMECC setting for subtarget: " << getSramEccSetting() << "\n");
----------------
Single quotes


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h:788
+    AMDGPU::IsaInfo::TargetIDSetting Setting = getSramEccSetting();
+    return hasD16LoadStore() &&
+           (Setting == AMDGPU::IsaInfo::TargetIDSetting::Off ||
----------------
Early exit if !hasD16LoadStore and avoid querying getSramEccSetting?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85882/new/

https://reviews.llvm.org/D85882