[PATCH] D85527: [AIX] Generate unique module id based on PID and timestamp

Thu Aug 13 17:30:27 PDT 2020

Xiangling_L marked 2 inline comments as done.
Xiangling_L added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/aix-static-init-no-unique-module-id.ll:15
+; way is not reproducible. A function name sample would be:
+; __sinit80000000_clang_119189_1597348415_0
+
----------------
hubert.reinterpretcast wrote:
> Xiangling_L wrote:
> > hubert.reinterpretcast wrote:
> > > Sorry for not mentioning this earlier, but could we replace `clang` here with `clangPidTime` or similar? More generally, I think we should want to indicate the format style in that position.
> > Do we only add indicator of format style when `getUniqueModuleId`[or source file full path later] does not work? i.e. do we also want to add one when `getUniqueModuleId`[or source file full path] does work and replace `clang` with something like `clangUniqueModId`[or `clangSrcFullPath`]?
> I think we would also want a format indicator for the other cases. This would help in case we find reasons for having more than one format available.
I see. Since "adding format indicator" doesn't really belong to the scope of this patch, and we will later have a follow-up patch of using source file full path to generate module id, I am thinking for this "the other case" we can leave a TODO and address it later? 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85527/new/

https://reviews.llvm.org/D85527