[PATCH] D83608: [NewPM][CodeGen] Introduce CodeGenPassBuilder to help build codegen pipeline

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 17:19:58 PDT 2020


ychen added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/CGPassBuilderOption.h:41-43
+  bool DisableLSR = false;
+  bool DisableCGP = false;
+  bool PrintLSR = false;
----------------
arsenm wrote:
> I think these need longer names and documentation comments
Sounds great. Comments added. I could do a followup patch for longer names. My intention was to make this close to a pure porting patch. WYDT? I don't mind put the renaming here though because they should be straightforward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83608/new/

https://reviews.llvm.org/D83608



More information about the llvm-commits mailing list