[PATCH] D85227: [Draft][MSAN] Cache stack traces and chained origins

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1109
+      IRBuilder<> IRB(ActualFnStart->getFirstNonPHI());
+      insertTracePrologue(IRB);
+    }
----------------
You need to move ActualFnStart below the new prologue, otherwise ex. the TLS store store will get instrumented with an address check, and a shadow store.

That's why I suggested to make it Instruction* and tweak the visitor loop to skip earlier instruction in the starting BB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85227/new/

https://reviews.llvm.org/D85227