[PATCH] D79485: [BPI] Improve static heuristics for "cold" paths.

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added a comment.

Is this work based on any paper/implementation?
Can we add some documentation at the top of the file to get an overall idea of the cost model?



================
Comment at: llvm/lib/Analysis/BranchProbabilityInfo.cpp:716
+/// 'unreachable', 'noreturn', 'cold', 'unwind' blocks. In addition it does its
+/// best to propogate the weight to up/down the IR.
+void BranchProbabilityInfo::computeEstimatedBlockWeight(
----------------
nit: inconsistent comments '//' vs '///'


================
Comment at: llvm/lib/Analysis/BranchProbabilityInfo.cpp:753
+        BBWeight = NORETURN_WEIGHT;
+      }
+    }
----------------
do we have a tab here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79485/new/

https://reviews.llvm.org/D79485