[PATCH] D85494: [WebAssembly] Allow inlining functions with different features

[Thomas Lively via Phabricator via llvm-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd53d952810e7: [WebAssembly] Allow inlining functions with different features (authored by tlively).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85494/new/

https://reviews.llvm.org/D85494

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.h
  llvm/test/Transforms/Inline/WebAssembly/inline-target-features.ll


Index: llvm/test/Transforms/Inline/WebAssembly/inline-target-features.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/Inline/WebAssembly/inline-target-features.ll
@@ -0,0 +1,41 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -mtriple=wasm32-unknown-unknown -S -inline | FileCheck %s
+
+; Check that having functions can be inlined into callers only when
+; they have a subset of the caller's features.
+
+target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
+target triple = "wasm32-unknown-unknown"
+
+declare void @foo()
+
+define internal void @uses_simd() #0 {
+; CHECK-LABEL: @uses_simd(
+; CHECK-NEXT:    tail call void @foo()
+; CHECK-NEXT:    ret void
+;
+  tail call void @foo()
+  ret void
+}
+
+define void @many_features() #1 {
+; CHECK-LABEL: @many_features(
+; CHECK-NEXT:    tail call void @foo()
+; CHECK-NEXT:    ret void
+;
+  tail call fastcc void @uses_simd()
+  ret void
+}
+
+define void @few_features() #2 {
+; CHECK-LABEL: @few_features(
+; CHECK-NEXT:    tail call fastcc void @uses_simd()
+; CHECK-NEXT:    ret void
+;
+  tail call fastcc void @uses_simd()
+  ret void
+}
+
+attributes #0 = { "target-cpu"="mvp" "target-features"="+simd128"}
+attributes #1 = { "target-cpu"="bleeding-edge" "target-features"="+simd128" }
+attributes #2 = { "target-cpu"="mvp" "target-features"="+multivalue" }
Index: llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.h
===================================================================
--- llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.h
+++ llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.h
@@ -67,6 +67,9 @@
   unsigned getVectorInstrCost(unsigned Opcode, Type *Val, unsigned Index);
 
   /// @}
+
+  bool areInlineCompatible(const Function *Caller,
+                           const Function *Callee) const;
 };
 
 } // end namespace llvm
Index: llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.cpp
===================================================================
--- llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.cpp
+++ llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.cpp
@@ -84,3 +84,21 @@
 
   return Cost;
 }
+
+bool WebAssemblyTTIImpl::areInlineCompatible(const Function *Caller,
+                                             const Function *Callee) const {
+  // Allow inlining only when the Callee has a subset of the Caller's
+  // features. In principle, we should be able to inline regardless of any
+  // features because WebAssembly supports features at module granularity, not
+  // function granularity, but without this restriction it would be possible for
+  // a module to "forget" about features if all the functions that used them
+  // were inlined.
+  const TargetMachine &TM = getTLI()->getTargetMachine();
+
+  const FeatureBitset &CallerBits =
+      TM.getSubtargetImpl(*Caller)->getFeatureBits();
+  const FeatureBitset &CalleeBits =
+      TM.getSubtargetImpl(*Callee)->getFeatureBits();
+
+  return (CallerBits & CalleeBits) == CalleeBits;
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85494.285490.patch
Type: text/x-patch
Size: 3116 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200813/83fdd3d7/attachment.bin>