[PATCH] D85870: sanitizer_common: Introduce internal_madvise and start using it.
Rainer Orth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 13 13:49:46 PDT 2020
ro added inline comments.
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_solaris.cpp:79
+// is defined as g++ does on Solaris.
+extern "C" int madvise(caddr_t, size_t, int);
+
----------------
I don't know why but you reintroduced an older/broken version of the `madvise` declaration here. The one you removed from `sanitizer_posix_libcdep.cpp` had the first arg as `void *` for a reason.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85870/new/
https://reviews.llvm.org/D85870
More information about the llvm-commits
mailing list