[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:204
+
+  return toSymbolEntry(Symb)->Obj32.Value;
 }
----------------
if we define 
getValue() for the  XCOFFSymbolRef
we rewrite the code as
Expected<uint64_t> XCOFFObjectFile::getSymbolAddress(DataRefImpl Symb) const {
return XCOFFSymRef(Symb, this).getValue();
}


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:211
+
+  return toSymbolEntry(Symb)->Obj32.Value;
 }
----------------
same as above comment.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:419
+      is64Bit() ? getNumberOfSymbolTableEntries64()
+                : getLogicalNumberOfSymbolTableEntries32();
+  SymDRI.p =
----------------
can we add new member function as getNumberOfSymbolTableEntries()
{
  return is64Bit() is64Bit() ? getNumberOfSymbolTableEntries64()
                : getLogicalNumberOfSymbolTableEntries32();
}

the function can also use in 
XCOFFObjectFile::create()
and
getSymbolNameByIndex()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85774/new/

https://reviews.llvm.org/D85774