[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D85787#2214038 <https://reviews.llvm.org/D85787#2214038>, @lebedev.ri wrote:

> @ reviewers - i'm not so much interested in deep code/algo review,
> but more like in the general direction disscussion, like, is this okay for instcombine? :)

The test diffs look great, and it seems to at least pay for itself in compile-time impact, so I think it's a good direction. There's always a question of "is this substantial enough (or would it grow enough with the 'TODO' items) to be a stand-alone pass?".

Haven't had a chance to look at the code itself yet. Do we have tests where there are extra uses of the extracted values?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85787/new/

https://reviews.llvm.org/D85787