[PATCH] D85527: [AIX] Generate unique module id based on PID and timestamp

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 10:50:29 PDT 2020


jasonliu added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1876
+          GlobalUniqueModuleId = llvm::utostr(sys::Process::getProcessId()) +
+                                 llvm::utostr(time(nullptr));
       }
----------------
time_t is likely to be a signed integral on most target, because specification required return (std::time_t)(-1) on error. 
So would it be better if we use llvm::itostr instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85527/new/

https://reviews.llvm.org/D85527



More information about the llvm-commits mailing list