[PATCH] D85881: Fix PR45442: Bail out when MemorySSA information is not available
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 13 09:55:37 PDT 2020
fhahn added inline comments.
================
Comment at: llvm/test/Transforms/GVNHoist/pr45442.ll:21
+entry:
+ br i1 undef, label %bb1, label %bb2
+
----------------
hiraditya wrote:
> fhahn wrote:
> > nit: branch on undef is UB, so it is probably best to avoid it and use a `i1 ` parameter or something instead
> Makes sense, i'll amend the testcase. The test case was reported in the PR so i added as is. Thanks for pointing out.
No worries! Also might be good to replace the unreachable with `ret void`, if it still reproduces the crash.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85881/new/
https://reviews.llvm.org/D85881
More information about the llvm-commits
mailing list