[PATCH] D77589: libclc: Add Mesa/SPIR-V target

Thu Aug 13 08:22:36 PDT 2020

daniels marked an inline comment as done.
daniels added a comment.

I've rebased this against current master whilst fixing @bbrezillon's comment.

@tstellar @jvesely Can one of you please land this, D83473: libclc: Fix FP_ILOGBNAN definition <https://reviews.llvm.org/D83473>, and D82078: libclc: Make all built-ins overloadable <https://reviews.llvm.org/D82078>? We are ready to merge the SPIR-V libclc support into Mesa for multiple drivers now, but are blocking on this being merged into LLVM trunk.

================
Comment at: libclc/CMakeLists.txt:286
+			set( opt_flags )
+			set( spvflags --spirv-max-version=1.1 --spirv-ocl-builtins-version=1.2 )
+		else()
----------------
bbrezillon wrote:
> Looks like the `--spirv-ocl-builtins-version` has been renamed to `--spirv-target-env` (see https://github.com/KhronosGroup/SPIRV-LLVM-Translator/commit/667bf137eeda7af93b482552c8959376e9565fc1#diff-8b7efcbcbffdd234c43aeda3bb73eaa5), and AFAICT, this should have been `--spirv-ocl-builtins-version="CL1.2"`.
> Maybe we can just drop this option since CL1.2 seems to be the default anyway.
Updated, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77589/new/

https://reviews.llvm.org/D77589