[PATCH] D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file.

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:570-571
+  // table entries for a detailed description. Since we support visibility, and
+  // all other bits are either optionally set or reserved, we only set the
+  // visibility bits 0-3,other bits are zero.
   // TODO Set the function indicator (bit 10, 0x0020) for functions
----------------
Space is needed after ',' 
Suggestion for comments: ... we only set bits 0-3 for symbol's visibility and leave other bits to zero.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:607
+  // all other bits are either optionally set or reserved, we only set the
+  // visibility bits 0-3,other bits are zero.
   // TODO FIXME How to assert a symbol's visibilty is default?
----------------
Keep it in sync with the above comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:608
+  // visibility bits 0-3,other bits are zero.
   // TODO FIXME How to assert a symbol's visibilty is default?
   // TODO Set the function indicator (bit 10, 0x0020) for functions
----------------
Remove this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84265/new/

https://reviews.llvm.org/D84265