[PATCH] D85628: [HotColdSplitting] Add command line options for supplying cold function names via user input.

[Jay Feldblum via Phabricator via llvm-commits]

yfeldblum added a comment.

In D85628#2214775 <https://reviews.llvm.org/D85628#2214775>, @hiraditya wrote:

> Added a patch to libcxxabi: https://reviews.llvm.org/D85873

The patch looks legit. Wonder if such a patch should be sent to libstdc++ too.

But will the compiler see these declarations though when compiling a source file containing a local static variable, in a way that will let it propagate coldness from the `__attribute__((cold))`? Or does the compiler have built-in knowledge of these functions - presumably it does since it emits calls to them - and will the compiler's built-in knowledge need to be extended in addition to this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85628/new/

https://reviews.llvm.org/D85628