[PATCH] D84100: [ARM][test] Add more tests of two-part immediates

Wed Aug 12 18:16:20 PDT 2020

benshi001 added a comment.

In D84100#2212804 <https://reviews.llvm.org/D84100#2212804>, @samparker wrote:

> I think the fact that you're having to make some Thumb2 changes to get around how the code is organised, suggests that the code should be reorganised instead. I'd suggest:
>
> - Pre-commit the two-part-imm.ll test.
> - Split the arm and thumb paths in an NFC patch, refactoring common code.
> - Then make your arm changes.

Thanks. This patch now only contains the improved test case two-part-imm.ll. And I will
submit the split of the arm and thumb paths in another NFC patch.

Really appreciate your suggestion.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84100/new/

https://reviews.llvm.org/D84100