[PATCH] D85467: [lld-macho] Support larger dylib symbol ordinals in bindings

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 17:22:11 PDT 2020


smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

In D85467#2203171 <https://reviews.llvm.org/D85467#2203171>, @int3 wrote:

>> we could produce 15 dylibs from the same source file and just have the 16th be different (to confirm the binding), right?
>
> yeah pretty much. It's just annoying that FileCheck doesn't provide a better way of testing things like this

Agreed.

I'd prefer to still add the test, but LGTM either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85467/new/

https://reviews.llvm.org/D85467



More information about the llvm-commits mailing list