[PATCH] D73964: [NFC] Introduce an API for MemOp

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:904
           TLI.allowsMisalignedMemoryAccesses(
-              VT, DstAS, Op.getDstAlign(), MachineMemOperand::MONone, &Fast) &&
+              VT, DstAS, Op.isFixedDstAlign() ? Op.getDstAlign().value() : 0,
+              MachineMemOperand::MONone, &Fast) &&
----------------
Why isn't this always passing the alignment? Why does isFixedDstAlign matter?

Passing 0 is broken in any case


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73964/new/

https://reviews.llvm.org/D73964