[PATCH] D84770: [llvm-libtool-darwin] Add support for -arch_only

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 16:39:56 PDT 2020


smeenai accepted this revision.
smeenai added a comment.

LGTM.

Let's commit this one as-is, and you can add arm64v8 to TextAPI and add the corresponding test here as a follow-up.



================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:133
+  case MachO::CPU_TYPE_ARM64:
+    if (ArchCPUSubtype == MachO::CPU_SUBTYPE_ARM64_ALL) {
+      return FileCPUSubtype == MachO::CPU_SUBTYPE_ARM64_ALL ||
----------------
Nit: you don't need braces, since both sides are simple return expressions (the first one is multi-line, but I think it's pretty clear it's part of the same statement).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84770/new/

https://reviews.llvm.org/D84770



More information about the llvm-commits mailing list